fix(coding-agent): restart dead kernels on ensure() and read mcp>=2 tool schemas - #2034
Open
snimu wants to merge 4 commits into
Open
fix(coding-agent): restart dead kernels on ensure() and read mcp>=2 tool schemas#2034snimu wants to merge 4 commits into
snimu wants to merge 4 commits into
Conversation
…ool schemas IpythonKernelProvisioner.ensure() cleared its memo only on startup failure, dispose, or kill; a kernel that died after a successful startup (OOM kill, os._exit) was handed out forever, wedging every later Python call. The memo now drops when the started kernel is no longer running, so the existing startKernel path (snapshot restore included) reruns. Separately, mcp>=2 renamed the Tool schema field to input_schema; mcp_base.py read only the inputSchema alias, so every skill-MCP tool advertised an empty schema. It now mirrors mcp.py's dual lookup.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b94d987. Configure here.
Protocol repair cycles the same manager through idle/starting while it respawns its child; the broad !isRunning check would abandon it and start a second kernel over the same snapshot directory. The memo now drops only for a defunct (shutdown-state) manager - the state an unexpected child exit parks in permanently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Two Python-runtime defects:
IpythonKernelProvisioner.ensure()memoizes the started kernel and cleared that memo only on startup failure, dispose, or kill. A kernel that died after a successful startup (OOM kill,os._exit, crash) was handed to every later Python call forever — each one failing against a dead process until the session restarted.ensure()now drops the memo when the started kernel is no longer running, so the existing startup path (snapshot restore included) reruns on the next call. Fixes the defect reported in discussion [Bug] v0.8.0 stopped IPython kernel remains permanently cached after unexpected exit #1659.mcp>=2renamed the Tool schema field toinput_schema(withinputSchemaas the wire alias); pydantic attribute access is by field name, somcp_base.py'sgetattr(t, "inputSchema", ...)was alwaysNoneand every skill-MCP tool advertised an empty{}schema — models called tools blind. The lookup now mirrors the dual lookup its siblingmcp.pyalready uses. Fixes the defect reported in discussion Fix: McpIntegration.list_tools() always returns empty inputSchema (#1073) #1757.Validation
input_schemasurfaces its schema throughlist_tools()(pre-fix:{})ipython-provisioner(20) andtest_mcp_base(18 viauv run python -m unittest) — greennpm run checkpasses via the pre-commit hookLOC
Total src: +20/−5 (net +15); tests: +50/−0 (net +50).
Src +14/−5 (both point fixes; the kernel fix is a 4-line liveness check ahead of the existing memo, the schema fix mirrors the sibling module's lookup). Tests +42, changelog 1 fragment.
Linear: RES-1266 https://linear.app/primeintellect/issue/RES-1266
Note
Medium Risk
Touches kernel lifecycle memoization and MCP tool metadata; behavior changes on post-crash recovery and tool listing, but scope is narrow with targeted tests.
Overview
Fixes two runtime bugs where sessions could get stuck on a dead Python kernel and skill-MCP tools could advertise empty parameter schemas.
Dead kernel memo:
IpythonKernelProvisioner.ensure()now clears its cached manager whenstartedManager.isDefunctis true (newKernelClient/ReplKernelManagerflag for terminalshutdown). The next Python call goes through the normal startup path—including snapshot restore—instead of reusing a process that died after a successful boot. Managers that are merely not running but still repairing stay memoized so a second kernel does not race on the snapshot dir.MCP tool schemas:
McpIntegration._ensure_toolsinmcp_base.pyresolves tool parameters viainput_schemafirst, theninputSchema, matchingmcp.pyand restoring realinputSchemametadata under mcp>=2 instead of always{}.Reviewed by Cursor Bugbot for commit 749e216. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix dead kernel restart on
ensure()and readinput_schemafor mcp>=2 toolsReplKernelManager.isDefunctand the requiredKernelClient.isDefunctproperty so callers can detect a terminal-shutdown kernel.IpythonKernelProvisioner.ensure()now drops the memoized manager and its startup promise when defunct, forcing a fresh kernel on the next call; non-defunct managers stay memoized.McpIntegration._ensure_toolsto readinput_schemafirst and fall back toinputSchemafor older MCP objects, keeping only dictionary schemas and substituting empty schemas otherwise.KernelClientimplementers must now provide the read-onlyisDefunctproperty; any out-of-tree implementation missing it will fail the interface contract.Macroscope summarized 749e216.