fix(coding-agent): never block opening the visible agents-view row on a pending selection anchor

[snimu]

Fixes RES-1314

Purpose

Opening a row in the agents view could be blocked for 5-10s+ with "Waiting for the selected session to load" — very frequently in a subagents (scoped) view, almost never in the main view. User intent now supersedes selection-anchor restoration: what you see is what Enter opens.

Root cause and asymmetry

restoreSelection() arms selectionAnchorPending whenever the remembered anchor (selectedRowIdentity/selectedSessionKey, incl. persisted state) cannot resolve against the current rows, and openSelected() blocked EVERY open while pending; the flag only cleared in resolveMissingSelectionAnchor() after the saved-catalog refresh settled.

Why the subagents view, specifically:

1. Entering a scoped view seeded the anchor with the entered-from chat — the scope ROOT — which is excluded from its own children view by design, so the anchor could NEVER resolve there; every scoped entry armed the wait for the full catalog scan.
2. Re-entering after opening a subagent anchors on that subagent, whose row lives only in the slow saved-catalog path (artifact-dir scan). Main-view anchors are usually daemon-resident rows that resolve instantly from the roster push, so the gate rarely armed there.

Changes (blocking semantics only; saved-catalog latency is #2043/#2051's scope)

• openSelected(): the pending gate and its status message are deleted. The handler is synchronous from keypress to finish() and acts on the row captured at entry (this.rows[this.selectedIndex]), so there is no window in which rows can reshuffle under the open; the "temporary fallback" row is a real rendered summary and opening it opens exactly that session. No residual case needs the message.
• queryChanged(): searching now claims the visible row as the new anchor (unconditional syncSelectedRowState), instead of preserving a stale anchor that could later yank the selection mid-search. Arrow-key navigation already claimed the row (moveSelection → syncSelectedRowState), which clears the pending flag — traced, unchanged.
• createInitialAgentsViewPersistentState(): a scoped entry no longer seeds the scope root as the selection anchor (it keeps backSession for Escape). This removes the guaranteed-unresolvable anchor from every subagents-view entry.
• Untouched sessions keep the restore behavior: while the user does nothing, restoreSelection keeps trying the remembered anchor on each catalog update and still lands on it when its row streams in; resolveMissingSelectionAnchor still adopts the fallback only after the saved catalog settles.

Tests (one pin per behavior, each proven fail-unfixed against the old code)

• 502 regression: Enter while the anchor is pending opens the visible row (was: pinned the blocking); same test still pins that the anchor identity survives for late re-anchoring and that fallback adoption waits for the catalog.
• Mode test: queryChanged claims the selection while the anchor is pending (extends the existing query test).
• State test: scoped entry seeds no selection anchor while unscoped entry still does (extends the existing scoped-navigation test); backSession retained.

LOC

Total src: +13/-12 (net +1); tests: +18/-1; changelog fragment +1.

Validation

• npm run check green (pre-commit hook); rebased onto v0.9.3 main (915c78f).
• agents-view-state (76), agents-view-mode (32), 502 regressions (15) green; reverting the src hunks fails exactly the three new pins.

---

Note

Low Risk
Small UX/selection-restore behavior change in agents view only; no auth, data, or security paths touched.

Overview
Fixes agents view Enter being blocked for seconds with "Waiting for the selected session to load" while a remembered selection was still resolving against the saved catalog—especially when opening a scoped (subagents) view.

Opening: openSelected() no longer gates on selectionAnchorPending; it always acts on the row under the cursor.

Scoped entry: createInitialAgentsViewPersistentState() stops seeding the scope root as the selection anchor (that row is excluded from its own children list, so the anchor could never resolve). backSession for Escape/back navigation is unchanged.

Search: queryChanged() always runs syncSelectedRowState() so typing a query adopts the visible row instead of holding a stale anchor.

Passive restore still re-anchors when the remembered row appears after catalog load; tests cover open-while-pending, search-while-pending, and scoped vs unscoped seeding.

^{Reviewed by Cursor Bugbot for commit d5b4926. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix AgentsViewMode.openSelected to not block on pending selection anchor

• Removes the guard in AgentsViewMode.openSelected that showed a waiting status and returned early when a remembered selection anchor was still pending; selectable rows now open immediately
• Makes AgentsViewMode.queryChanged always sync selection to visible rows after a query change, instead of skipping sync while an anchor is pending
• Changes createInitialAgentsViewPersistentState so scoped agents-view initialization no longer seeds the entered-from session as a selected-row anchor; the session remains available as backSession for scope navigation
• Behavioral Change: Enter on a pending-anchor row now performs the row's normal open or toggle action instead of emitting a waiting message; query changes always resync selection to the visible row

^{Macroscope summarized d5b4926.}

[sethkarten]

Included in #2068: #2068