fix(coding-agent): always render inactive sessions in the agents view - #2091
Merged
Conversation
Partially reverts #2087's inactive-collapse (merged via the #2068 consolidation) per user decision: inactive sessions always render and search is the filter. Removes the Alt+I keybinding (unreachable on default macOS terminals, where the composed character feeds the always-focused search editor), the compactSessionRows inactive gating, and the persisted inactiveExpanded flag; stale flags from older state objects are ignored. The subagent-summary row folding stays. Fixes RES-1316.
…ive-visibility change
sethkarten
self-requested a review
September 8, 2026 22:35
sethkarten
approved these changes
Sep 8, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RES-1316
Purpose
Inactive sessions must always render in the agents view; search is the filter. This partially reverts #2087's inactive-collapse ("Collapsed inactive sessions by default. Search still includes them; Alt+I toggles the section."), which was merged via the #2068 consolidation. Beyond the product decision, the Alt+I toggle is unreachable on default macOS terminals: the composed character goes to the always-focused search editor, so users could not reveal the hidden sessions.
Changes (surgical revert of one feature; everything else from the #2068 consolidation stays)
compactSessionRowsno longer gates depth-0 blocks on the inactive section; it keeps foldingsubagent-summaryrows (that folding serves the running-subagents display items, which remain).showInactiveplumbing (the query no longer doubles as a reveal switch — it filters, as before the collapse).app.agents.inactiveCollapsekeybinding (type map +alt+idefault), its input handler, the Inactive-header▸/▾prefix + Alt+I hint, and the actions-panel line.persistentState.inactiveExpanded(writer + type). The state object is in-process only — it is never serialized to disk — so a stale property from an older view instance is simply never read; nothing needs migration.Tests
inactiveExpanded: falseis ignored, the old Alt+I chord hides nothing, and search still narrows to matches only.LOC
Total src: +7/−36 (net -29); tests: +10/−12 (net -2). Net-negative surgical revert: the inactive-collapse gating,
alt+ikeybinding, header hint, actions line, and persisted flag deleted; kept consolidation features untouched. +1 changelog fragment.Validation
npm run checkgreen (pre-commit hook).Note
Low Risk
Agents-view UI and list filtering only; no auth, daemon protocol, or persistence migration changes.
Overview
Inactive sessions are always visible in the agents view; the Alt+I collapse toggle is removed because it was hard to reach when search input captures keys on macOS.
Row building no longer hides the inactive section:
compactSessionRowsonly dropssubagent-summaryrows, and search text filters the list instead of acting as a reveal switch. UI cleanup removes the inactive header ▸/▾ affordance, the actions-panel hint, andapp.agents.inactiveCollapsefrom keybindings.inactiveExpandedis dropped from in-process persistent state (stale values are ignored).Tests now assert inactive rows appear on load, Alt+I does nothing, and only a non-matching search hides them.
Reviewed by Cursor Bugbot for commit 12fefcd. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Always render inactive sessions in
agents-view-modeRemoves the collapse/expand toggle for inactive sessions in the agents view so they always render. Search remains the only way to filter sessions out.
app.agents.inactiveCollapsekeybinding (Alt+I) from keybindings.ts and theinactiveExpandedpersistent-state property from agents-view-mode.tsshowInactiveparameter fromcompactSessionRows; inactive top-level rows are always retained and only subagent-summary rows are foldedinactiveExpandedstate from older sessions is now ignored; no migration is performed, but the stale value has no effectMacroscope summarized 12fefcd.