chore: capture Agno golden system messages for migration ground truth#86
Open
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Open
chore: capture Agno golden system messages for migration ground truth#86Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Conversation
Captures exact system messages Agno produces for all 6 review modes, both cloud (no schema injection) and local (with JSON schema prompt). These golden files are the Phase 3 verification ground truth. Key findings: - Single system message per mode - Agno prefixes each instruction with "- " (use_instruction_tags=False) - No model-injected instructions (get_instructions_for_model returns None) - Local transport adds +7837 chars JSON schema via get_json_output_prompt() - 12 instructions per mode across all 6 modes
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
❌ Grippy Review — DIFF ERRORReview failed. Check the Actions log for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures exact system messages Agno produces for all 6 review modes, both cloud (no schema injection) and local (with JSON schema prompt). These golden files are the Phase 3 verification ground truth for the Agno-to-LiteLLM migration and cannot be reconstructed after Agno is removed.
Split from #83 because the ~24K lines of fixture text triggered a 406 from GitHub's diff API, preventing Grippy from self-reviewing.
Key findings documented in metadata.txt
"- "(use_instruction_tags=False)Scope limitation (per Grumpy audit)
These capture Agno's OpenAILike/local message construction path. They do NOT capture provider-specific request bodies or provider-class behavior. Provider-level capture is a Phase 3 prerequisite.
Test plan
uv run python scripts/capture_agno_golden.py