Skip to content

[FIX] Cleaned up low alpha pixels from body_base - #640

Merged
Jomshir98 merged 4 commits into
Project-Pandora-Game:masterfrom
Nikky90506:body-base-cleanup
Jul 22, 2026
Merged

Jomshir98 merged 4 commits into
Project-Pandora-Game:masterfrom
Nikky90506:body-base-cleanup

Conversation

@Nikky90506

@Nikky90506 Nikky90506 commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

References

I don't think there's any particular issue created for this:

picture

About The Pull Request

Goal

Turns out all of the layers for Base Body have "stray almost-transparent pixels at random places". The goal was to remove most glaring cases of these.

How

The idea was to find minimal alpha value threshold at which selecting outer transparent pixels didn't result in any "islands" and then deleting all the pixels in the selection. So threshold was found manually for each layer, I think it was 30 at most. Honestly, it could probably be even more, but I decided to err on the side of caution.

Example

Body_back changes

Before:
Body_back_before

After:
Body_back_after

Notes

By nature of this change it's very unlikely to be able to see the differences visually, but you may notice the reduced filesize of layers.

It can be checked manually though, by using your preferred editor. For Krita, it would be choosing "Similar Color Selection Tool", setting Tool Options -> Selection extent -> Threshold to minimum and clicking on outer transparent area of the layer.

Krita interface Krita

I didn't like trying to use Krita for the cleanup though, as it handles such selections weirdly and used GIMP instead. But it's enough to see the issue.

It might be a good idea to add this to asset creation tutorial as we have other assets with similar problem. I didn't want to go through the whole repo at once and decided to keep the scope to Body Base. But, for example, Asian Dress has a little of these stray pixels too. Probably some kind of automated check could be devised for this, but that's an idea for another day.

GIMP vs Krita

Example of differences between Krita and GIMP. While GIMP selects all pixels below Threshold, Krita... I'm not exactly sure what happens.

GIMP
GIMP-example

Krita
Krita-example

Changelog

Authored by: Nikky

Assets:
- [Base Body] Cleaned up stray low alpha pixels from all layers

Checklist

  • The change has been tested locally
  • Licensing information and credits were filled in/modified for added/modified assets
  • I understand this change is licensed based on Pandora's Asset Licensing information

@Nikky90506 Nikky90506 changed the title Cleaned up low alpha pixels from body_base [FIX] Cleaned up low alpha pixels from body_base Jul 13, 2026
@Nikky90506

Copy link
Copy Markdown
Contributor Author

Oh, so tests check hash of core assets...
Though I can't think of a way it could be updated at the same time anyway, considering hash is in another repo.

@ClaudiaMia

Copy link
Copy Markdown
Contributor

Oh, so tests check hash of core assets... Though I can't think of a way it could be updated at the same time anyway, considering hash is in another repo.

Yes, Jomshir will take care of that.

Thank you for this cleanup!
We will take a look at it soon.

@Jomshir98
Jomshir98 merged commit dc0c672 into Project-Pandora-Game:master Jul 22, 2026
5 checks passed
@Nikky90506
Nikky90506 deleted the body-base-cleanup branch August 18, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants