java 17 #103
Merged
java 17 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project's Java runtime requirement from Java 8 to Java 17 across all build and packaging configurations.
- Updated all platform-specific packaging scripts to bundle Java 17 JRE from Adoptium
- Modified Linux distribution package specifications to require Java 17
- Updated Gradle toolchain configuration and documentation
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package-win.sh | Updated Adoptium API URL to download Java 17 JRE for Windows packages |
| package-macos.sh | Updated Adoptium API URL to download Java 17 JRE for macOS packages |
| package-linux.sh | Updated Adoptium API URL to download Java 17 JRE for Linux packages |
| fedora-package/SPECS/numberguessinggame.spec | Changed RPM dependency from java-1.8.0-openjdk-headless to java-17-openjdk-headless |
| debian-package/DEBIAN/control | Simplified DEB dependency to default-jre (which provides Java 17+ on modern distributions) |
| app/build.gradle | Updated Gradle Java toolchain from version 8 to 17, removed outdated comment |
| README.md | Updated documentation to reflect Java 17 minimum requirement |
| .gitignore | Changed Linux archive extension from .tar.gz to .tar.xz (consistent with packaging script) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.