feat: add blake3 option for second public input - #522
Open
VanhGer wants to merge 6 commits into
Open
Conversation
eigmax
reviewed
Aug 1, 2026
| /// feature is enabled. | ||
| /// By default, the variable is disabled. | ||
| pub fn zkm_imm_wrap_vk_mode() -> bool { | ||
| let value = std::env::var("ZKM_IMM_WRAP_VK").unwrap_or_else(|_| "false".to_string()); |
Member
There was a problem hiding this comment.
do we have to use std in the zkm::primitives? any other way to distinguish whether ZKM_IMM_WRAP_VK is enabled?
Contributor
Author
There was a problem hiding this comment.
zkm-primitives is already a plain std crate everywhere, not no_std.
Contributor
Author
There was a problem hiding this comment.
right now it just has only way which checks the env ZKM_IMM_WRAP_VK is set to 1 or 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.