refactor(tests): split event stats/attendance-api tests (Issue 1318) - #1335
Merged
Merged
Conversation
… (Issue 1318) test_event_stats.py mixed helper unit tests (_cancellations, _resolve_cancelled_at, rsvp counts) with API endpoint tests (TestStatsEndpoint, TestSetAttendance). Split the API endpoint classes into test_event_attendance_api.py, which imports the shared fixtures + _auth helper from test_event_stats. No behavior change — pure move, done ahead of PR #1323 (which would otherwise push this file over the 500-line hard cap).
leahpeker
force-pushed
the
refactor-split-event-stats-tests
branch
from
August 8, 2026 14:25
f9294b0 to
7421b56
Compare
leahpeker
added a commit
that referenced
this pull request
Aug 8, 2026
test_event_attendance_api.py arrived from main (PR #1335 split it out of test_event_stats.py) still referencing AttendanceStatus.NO_SHOW, which this branch renamed to DIDNT_GO. No textual conflict since the file is new here, so the rebase couldn't surface it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/tests/test_event_stats.pyinto two files: helper unit tests stay intest_event_stats.py, API endpoint tests (TestStatsEndpoint,TestSetAttendance) move to a newtest_event_attendance_api.py.Test plan
make agent-lint— cleanmake agent-typecheck— cleantest_event_stats.py,test_event_attendance_api.py) — 30/30 passed