Conversation
… (Issue 1433) The backend already set `event` on payment-revoked notifications, but the frontend had no `PaymentRevoked` case in `notificationTarget`, so it fell through to `null` and the row was not clickable. A guest told their payment needed attention had no way to reach the event to reconfirm. Closes #1433
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The backend already attached the event to payment-revoked notifications, but the frontend had no
PaymentRevokedcase innotificationTarget, so it fell through tonulland the row rendered as non-clickable. A guest told their payment "needs attention" had no way to reach the event to reconfirm.Adds the missing notification type to the frontend mirror and routes it to
/events/{eventId}, exactly as the other event-scoped notification types already do.Note: the issue body was empty, so the intended behaviour was inferred from the surrounding code — specifically that every other event-scoped notification type already links to its event, and this one was the only omission.
Test plan
make agent-frontend-test— 156 files, 1274 passedmake agent-frontend-lint,make agent-frontend-typecheckevent=eventand emits the exact stringpayment_revoked, soeventIdis populatedcaseis removedCloses #1433
🤖 Generated with Claude Code