Clarify limitations of 'Open' for PsychPortAudio#14
Open
TEParsons wants to merge 1 commit intoPsychtoolbox-3:masterfrom
Open
Clarify limitations of 'Open' for PsychPortAudio#14TEParsons wants to merge 1 commit intoPsychtoolbox-3:masterfrom
TEParsons wants to merge 1 commit intoPsychtoolbox-3:masterfrom
Conversation
The wording of the documentation for PsychPortAudio('Open') gives the impression that only one stream per device can ever be opened, but calling `run` from [the Python demo for PPA](https://github.com/Psychtoolbox-3/Psychtoolbox-3/blob/master/PsychPython/demos/ppatest_pythonic.py), which opens and closes a new stream each time, works fine when called multiple times in a single session. The proposed wording clarifies that the limitation is one stream *at a time* rather than one stream *total*.
The link to docs for 'OpenSlave' was also broken, so I added the prefix `PsychPortAudio-` while in the neighbourhood.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording of the documentation for PsychPortAudio('Open') gives the impression that only one stream per device can ever be opened, but calling
runfrom the Python demo for PPA, which opens and closes a new stream each time, works fine when called multiple times in a single session. The proposed wording clarifies that the limitation is one stream at a time rather than one stream total.The link to docs for 'OpenSlave' was also broken, so I added the prefix
PsychPortAudio-while in the neighbourhood.