Skip to content

return empty string on hid success error #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickwierenga merged 2 commits into from
Feb 3, 2026
Merged

return empty string on hid success error #869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e359cd
return empty on hid success error
rickwierenga Feb 3, 2026
0dce436
type
rickwierenga Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pylabrobot/io/hid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

try:
import hid # type: ignore
from hid import HIDException

USE_HID = True
except ImportError as e:
Expand Down Expand Up @@ -156,7 +157,12 @@ async def read(self, size: int, timeout: int) -> bytes:

def _read():
assert self.device is not None, "forgot to call setup?"
return self.device.read(size, timeout=int(timeout))
try:
return self.device.read(size, timeout=int(timeout))
except HIDException as e:
if str(e) == "Success":
return b""
raise

if self._executor is None:
raise RuntimeError("Call setup() first.")
Expand Down