Skip to content

Conversation

@smondal13
Copy link
Contributor

@smondal13 smondal13 commented Dec 3, 2025

Fixes # .

Summary/Motivation:

Consolidates the different copies of rooney_biegler.py into a single copy.

Changes proposed in this PR:

-Merge multiple copies of rooney_biegler example in parmest and DoE into a single copy.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@smondal13
Copy link
Contributor Author

smondal13 commented Dec 3, 2025

@adowling2 @blnicho, I have consolided the copies of rooney_biegler from ParmEst and DoE. This is ready for review. I do not think we need any new test for this one if other tests that use this pass.

@smondal13 smondal13 moved this to Ready for final review in ParmEst & Pyomo.DoE Development Dec 3, 2025
@smondal13 smondal13 moved this from Ready for final review to Ready for design review in ParmEst & Pyomo.DoE Development Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.43%. Comparing base (a079b25) to head (86d6b68).

Files with missing lines Patch % Lines
...les/rooney_biegler/parameter_estimation_example.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3793      +/-   ##
==========================================
+ Coverage   89.41%   89.43%   +0.01%     
==========================================
  Files         909      906       -3     
  Lines      105579   105444     -135     
==========================================
- Hits        94407    94303     -104     
+ Misses      11172    11141      -31     
Flag Coverage Δ
builders 29.15% <59.37%> (+0.02%) ⬆️
default 86.05% <87.50%> (?)
expensive 35.76% <62.50%> (?)
linux 86.74% <87.50%> (-2.45%) ⬇️
linux_other 86.74% <87.50%> (+0.01%) ⬆️
osx 82.92% <87.50%> (+0.03%) ⬆️
win 84.99% <87.50%> (+0.01%) ⬆️
win_other 84.99% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smondal13 smondal13 moved this from Ready for design review to Ready for final review in ParmEst & Pyomo.DoE Development Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Ready for final review

Development

Successfully merging this pull request may close these issues.

5 participants