feat: add offline.mode config to disable the service worker - #49
Merged
Conversation
offline.mode defaults to cache-first (unchanged). Setting it to 'none' eliminates the service worker and all its caching: no sw.js at the site root or in assets, no cache-manifest.json, no manifest.json, and pages carry no SW registration or manifest link. Also regenerates docsforge/templates/base.html with the current pinned html-minifier-terser 7.2.0, which no longer minifies inline scripts that contain Jinja fragments (the committed templates were stale from an older toolchain version).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
offline.modeconfig option to switch the service worker off entirely.cache-first(unchanged): SW registers, precaches every page/asset, serves from cache first.none: nosw.js, nocache-manifest.json, nomanifest.json, no SW registration or manifest link in pages.Also regenerates the committed templates with the pinned html-minifier-terser 7.2.0 (the committed templates were stale from an older toolchain; 7.2.0 no longer minifies inline scripts containing Jinja fragments).
Tests: config default/validation unit tests + e2e none-mode build check.