Adding filled dialect to represent grids with vacancies in it.
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Copilot finished reviewing on behalf of
weinbe58
December 1, 2025 21:04
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new filled dialect to represent grids with vacancies, allowing users to work with grids that have some positions marked as vacant. The implementation includes type definitions, statements, concrete interpreters, and comprehensive test coverage.
- Introduces
FilledGridclass that wraps a parent grid and tracks vacant positions - Adds
vacateandfilloperations to mark positions as vacant or filled - Updates the dependency from
kirin-toolchain~=0.18.0tokirin-toolchain~=0.22.0
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/grid/test_typeinfer.py | Updated import path to use dialects subpackage |
| test/grid/test_concrete.py | Updated import path to use dialects subpackage |
| test/filled/test_api.py | Added comprehensive tests for filled grid operations |
| test/filled/init.py | Created test package for filled dialect |
| src/bloqade/geometry/prelude.py | Integrated filled dialect into geometry dialect group |
| src/bloqade/geometry/dialects/grid/types.py | Removed SliceAttribute handling; added row_x_pos and col_y_pos methods |
| src/bloqade/geometry/dialects/grid/stmts.py | Added RowXPos and ColYPos statement definitions |
| src/bloqade/geometry/dialects/grid/concrete.py | Implemented concrete interpreters for new grid statements |
| src/bloqade/geometry/dialects/grid/_interface.py | Added interface functions for row_xpos and col_ypos |
| src/bloqade/geometry/dialects/filled/types.py | Defined FilledGrid type with vacancy tracking and grid operations |
| src/bloqade/geometry/dialects/filled/stmts.py | Defined Vacate, Fill, and GetParent statements |
| src/bloqade/geometry/dialects/filled/concrete.py | Implemented concrete interpreters for filled operations |
| src/bloqade/geometry/dialects/filled/_interface.py | Defined interface functions for vacate, fill, and get_parent |
| src/bloqade/geometry/dialects/filled/_dialect.py | Created dialect definition for filled |
| src/bloqade/geometry/dialects/filled/init.py | Exported filled dialect components |
| src/bloqade/geometry/init.py | Exposed filled and grid interfaces at package level |
| pyproject.toml | Updated kirin-toolchain dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ported from bloqade-shuttle as it is more widely applicable.