Merged
Conversation
benetem
approved these changes
Mar 26, 2025
MBreathe
approved these changes
Mar 26, 2025
Collaborator
MBreathe
left a comment
There was a problem hiding this comment.
still not over you re-writing if statements, but the rest lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alright guys, this is it.
I hope that this could be the last PR for this project.
I learned something new, and I thought to share it with you guys. You will find a couple of functions in questionPage.js starts with
run.For examplerun.nextQuestion, orrun.skipQuestion. That's because I imported all the functions from the new file without declaring each one of them by using the following import statementimport * as run from './questionPageFunctions.js' //You can replace "run" with any keyword.