[examples/llama3] Add FP4 option #123
Open
matthiasdiener wants to merge 7 commits intosudhu/Megatron-IFU-core_0.16.0_syncfrom
Open
[examples/llama3] Add FP4 option #123matthiasdiener wants to merge 7 commits intosudhu/Megatron-IFU-core_0.16.0_syncfrom
matthiasdiener wants to merge 7 commits intosudhu/Megatron-IFU-core_0.16.0_syncfrom
Conversation
…e asset handling - Added `uvicorn` to the Dockerfile dependencies. - Replaced mamba installation method with `mamba-ssm` - Included cloning and installation of the Emerging Optimizers repository in the Dockerfile. - Enhanced the `download_and_extract_asset` function to ensure the assets directory is created if it doesn't exist. - Updated unit tests to conditionally import and test features from Emerging Optimizers, skipping tests if the package is not available. - Added pytest markers to ensure compatibility checks for specific versions in various tests.
…orBoard - Introduced `cpu_offloading_num_layers` argument in the network size configuration. - Added `log_batch_size_to_tensorboard` option in LoggerConfig to enable batch size logging. - Fixed variable name in `download_and_extract_asset` function for clarity.
- Updated the logging condition in `HyperCommGrid` to check if the distributed environment is initialized before logging. - Modified `cuda_graphs.py` to conditionally import `make_weak_ref` and set a flag for its availability. - Adjusted tests for experimental logging to utilize a new utility function for rank checking, ensuring accurate log assertions across distributed ranks. - Refactored CPU offloading arguments from the argument parser
- Added a condition to check if `num_experts` is not None before asserting the need for sequence parallelism
Co-authored-by: sudhu2k <Sudharshan.Govindan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Tested with ROCm/TransformerEngine#518
Test Result
Submission Checklist