Replace lambdas with named functors in transform_tensor_descriptor #3589
+72
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenpercent
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
vidyasagar-amd and
vpietila-amd
as code owners
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
3 times, most recently
from
748497a to
885b80f
Compare
This was referenced Jan 16, 2026
1 task
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
885b80f to
0791bad
Compare
tenpercent
force-pushed
the
tenpercent/generate-identity-sequences
branch
from
ef35913 to
7c37209
Compare
2 tasks
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
0791bad to
b26ed88
Compare
Lambda expressions in transform_tensor_descriptor created unique template instantiations for each capture combination. This change replaces lambdas with named functor structs to reduce instantiation count: - Add merge_sequences_functor and unpack_and_merge_sequences helper - Add convert_visible_to_hidden_id and convert_visible_ids_to_hidden_ids - Add generate_arithmetic_sequence_from_scan Build analysis shows instantiation count dropped from 388 to 32 (92% reduction).
tenpercent
force-pushed
the
tenpercent/generate-identity-sequences
branch
from
7c37209 to
d7e7fbd
Compare
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
b26ed88 to
00849ac
Compare
This was referenced Jan 19, 2026
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
transform_tensor_descriptortransform_tensor_descriptorinstantiations from 388 to 32 (92% reduction)Changes
unpack_and_merge_sequenceshelper to replace lambda inGetNumOfHiddenDimensiongenerate_identity_sequencesinmatrix_padder.hppWhy It Works
Each lambda creates a unique closure type, causing
transform_tensor_descriptorto be instantiated separately for every call site. Named functors share a single type, so the compiler reuses the same instantiation.Test Plan
PR Stack
__make_integer_seqTracking issue: #3575