Skip to content

[CK Profiler] Restore CPU tensor initialization when verification is not done on GPU #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
illsilin merged 3 commits into from
Jan 16, 2026
Merged

[CK Profiler] Restore CPU tensor initialization when verification is not done on GPU #3594

illsilin merged 3 commits into from
Jan 16, 2026

Conversation

@johannes-graner
Copy link
Contributor

@johannes-graner johannes-graner commented Jan 16, 2026 •
edited
Loading

Proposed changes

With #3550 merged, the large case tests fail in the nightly CI. This PR restores CPU-side initialization when either no verification is done, or verification is performed on CPU (i.e. when do_verification != 2).

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merge

@johannes-graner johannes-graner changed the title [Tests] Fix large case init bounds [CK Profiler] Restore CPU tensor initialization when verification is not done on GPU Jan 16, 2026
@illsilin illsilin merged commit 3f735c1 into develop Jan 16, 2026
23 checks passed
@illsilin illsilin deleted the jograner/conv-large-case-fix branch January 16, 2026 18:56
Zakhrov pushed a commit to Zakhrov/composable_kernel that referenced this pull request Jan 17, 2026
@johannes-graner @Zakhrov
[CK Profiler] Restore CPU tensor initialization when verification is …
56eebc0 
…not done on GPU (ROCm#3594)

* Fix large case init bounds

* Revert "Fix large case init bounds"

This reverts commit 1abca05.

* Restore CPU initialization for do_verification != 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartekxk bartekxk bartekxk approved these changes

@illsilin illsilin illsilin approved these changes

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

@ThomasNing ThomasNing Awaiting requested review from ThomasNing ThomasNing is a code owner

@coderfeli coderfeli Awaiting requested review from coderfeli coderfeli is a code owner

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@shumway shumway Awaiting requested review from shumway shumway is a code owner

@vidyasagar-amd vidyasagar-amd Awaiting requested review from vidyasagar-amd vidyasagar-amd is a code owner

@vpietila-amd vpietila-amd Awaiting requested review from vpietila-amd vpietila-amd is a code owner

@Snektron Snektron Awaiting requested review from Snektron Snektron is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johannes-graner @bartekxk @illsilin