Merged
Conversation
- netdev names with underscore is now supported - regex match group dereference should be guarded dereference only when match is non-null Signed-off-by: Ahsan Kabir <Ahsan.Kabir@amd.com>
cijohnson
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR will allow supporting netdevs that have names with underscore
Technical Details
Changes were made to regex to support regex. This comes in the path of perftest
Test Plan
Created unit test case to test netdev names with underscore
Test Result
Ran the recommended tests and formatting before pushing the branch
Submission Checklist