Add pre-commit configs and update README for pre-commit setup#95
Open
abalasa-amd wants to merge 4 commits intomainfrom
Open
Add pre-commit configs and update README for pre-commit setup#95abalasa-amd wants to merge 4 commits intomainfrom
abalasa-amd wants to merge 4 commits intomainfrom
Conversation
- Introduced a new .pre-commit-config.yaml file to set up pre-commit hooks for linting and formatting. - Updated README.md to include instructions for installing and using pre-commit hooks, ensuring consistent code quality across commits. - Added a CI job in ci.yml to run pre-commit checks on changed files during pull requests.
…uctions - Updated Makefile to include a new target for installing pre-commit hooks. - Adjusted CI workflow to ensure linting is a prerequisite for testing jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure consistent code quality across commits.
Technical Details
Test Plan
Followed instructions locally and it worked.
Test Result
Run checks while creating the commit using
git commitSubmission Checklist