[CP 1386] [CP 1363] handle reboot step failure in workflow#531
Open
ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
Open
[CP 1386] [CP 1363] handle reboot step failure in workflow#531ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
Conversation
* handle reboot step failure in workflow * fix node selector and affinity rules * update documentation * use boot id to detect successful reboot * ignore tests folder from docs lint (cherry picked from commit 1c647b6169de2f320a4b5bf164a49f3450b44bbf) Co-authored-by: Uday Bhaskar <udayb@amd.com> (cherry picked from commit 2225463b9b2cdd61376c06deddd0a6bdde052a7b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1386
Source PR Description (pensando/gpu-operator#1386):
When rebooting a remediation node, the reboot workflow step ran as a pod on the node being rebooted. This caused the pod to be killed mid-execution, which Argo interpreted as a step failure.
To fix this, the single reboot step has been split into two separate steps:
Reboot — issues the reboot command and exits gracefully before the node goes down.
WaitForNodeReady — waits for the rebooted node to come back online and report as ready.
This separation ensures the reboot pod shuts down cleanly and the workflow correctly tracks node recovery without false failures.
Cherrypick triggered by: ACP-Automation