Skip to content

[Fix] Correct misspellings across source and test files #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leo8a wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Correct misspellings across source and test files #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/deviceconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ type TestRunnerSpec struct {
// +optional
ImageRegistrySecret *v1.LocalObjectReference `json:"imageRegistrySecret,omitempty"`

// config map to customize the config for test runner, if not specified default test config will be aplied
// config map to customize the config for test runner, if not specified default test config will be applied
//+operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Secret",xDescriptors={"urn:alm:descriptor:com.amd.deviceconfigs:configmap"}
// +optional
Config *v1.LocalObjectReference `json:"config,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions internal/controllers/device_config_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ func (dcrh *deviceConfigReconcilerHelper) finalizeDeviceConfig(ctx context.Conte
}
} else {
// driver disabled mode won't have KMM CR created
// but it still requries the removal of node labels
// but it still requires the removal of node labels
if err := dcrh.updateNodeLabels(ctx, devConfig, nodes, true); err != nil {
logger.Error(err, "failed to update node labels")
}
Expand Down Expand Up @@ -1267,7 +1267,7 @@ func (dcrh *deviceConfigReconcilerHelper) handleNodeLabeller(ctx context.Context
if err := dcrh.updateNodeLabels(ctx, devConfig, nodes, false); err != nil {
logger.Error(err, "failed to remove node labeller's labels when node labeller is disabled")
}
logger.Info("skip handling node labeller as it is disbaled", "namespace", devConfig.Namespace, "name", devConfig.Name)
logger.Info("skip handling node labeller as it is disabled", "namespace", devConfig.Namespace, "name", devConfig.Name)
return nil
}

Expand Down
6 changes: 3 additions & 3 deletions internal/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestShouldUseKMM(t *testing.T) {
Expect: false,
},
{
Description: "enbale driver management with container driver type",
Description: "enable driver management with container driver type",
DevConfig: &v1alpha1.DeviceConfig{
Spec: v1alpha1.DeviceConfigSpec{
Driver: v1alpha1.DriverSpec{
Expand All @@ -249,7 +249,7 @@ func TestShouldUseKMM(t *testing.T) {
Expect: true,
},
{
Description: "enbale driver management with vf-passthrough driver type",
Description: "enable driver management with vf-passthrough driver type",
DevConfig: &v1alpha1.DeviceConfig{
Spec: v1alpha1.DeviceConfigSpec{
Driver: v1alpha1.DriverSpec{
Expand All @@ -261,7 +261,7 @@ func TestShouldUseKMM(t *testing.T) {
Expect: true,
},
{
Description: "enbale driver management with pf-passthrough driver type",
Description: "enable driver management with pf-passthrough driver type",
DevConfig: &v1alpha1.DeviceConfig{
Spec: v1alpha1.DeviceConfigSpec{
Driver: v1alpha1.DriverSpec{
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ func (s *E2ESuite) TestDeploymentWithPreInstalledKMMAndNFD(c *C) {
}
utils.RunCommand(kmmInstallCommand)

logger.Infof("Deploying GPU opertor without NFD and KMM Operator")
logger.Infof("Deploying GPU operator without NFD and KMM Operator")
// Deploy GPU operator. Skip NFD and KMM
utils.RunCommand(deployWithoutNFDKMMCommand)

Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/exporter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ func (s *E2ESuite) TestHealthCheckFeature(c *C) {
LabelSelector: labels.SelectorFromSet(rocmLabel).String(),
})
if err != nil {
logger.Printf("Error occured when trying to get the pod. Error: %v", err)
logger.Printf("Error occurred when trying to get the pod. Error: %v", err)
return false
}
if pods == nil || len(pods.Items) == 0 {
Expand Down Expand Up @@ -409,7 +409,7 @@ func (s *E2ESuite) TestHealthCheckFeature(c *C) {
LabelSelector: labels.SelectorFromSet(rocmLabel).String(),
})
if err != nil {
logger.Printf("Error occured when trying to get the pod. Error: %v", err)
logger.Printf("Error occurred when trying to get the pod. Error: %v", err)
return false
}
if pods == nil || len(pods.Items) == 0 {
Expand Down Expand Up @@ -443,7 +443,7 @@ func (s *E2ESuite) TestHealthCheckFeature(c *C) {
LabelSelector: labels.SelectorFromSet(rocmLabel).String(),
})
if err != nil {
logger.Printf("Error occured when trying to get the pod. Error: %v", err)
logger.Printf("Error occurred when trying to get the pod. Error: %v", err)
return false
}
if pods == nil || len(pods.Items) == 0 {
Expand Down