[CP 297] Add CNI plugins service account and values for K8s Helm chart (#297)#72
Merged
sundar-pds merged 1 commit intoROCm:mainfrom Apr 21, 2026
Merged
Conversation
* Add CNI plugins service account and values for K8s Helm chart - Add cniPlugins.serviceAccount.annotations to values.yaml - Add CNI plugins service account to serviceaccount.yaml template - Fixes helm lint error: nil pointer evaluating cniPlugins.serviceAccount - Required for K8s Helm chart build to support CNI plugins RBAC The CNI plugins service account is needed in vanilla K8s deployments even though the RBAC file is removed (OpenShift-specific). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Address review comments Signed-off-by: Yuva Shankar <11082310+yuva29@users.noreply.github.com> ---------
yuva29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CNI plugins service account is needed in vanilla K8s deployments even though the RBAC file is removed (OpenShift-specific).
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Signed-off-by: Yuva Shankar 11082310+yuva29@users.noreply.github.com
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist