Skip to content

[CP 300] Fix multus config detection to support both .conf and .conflist formats (#300)#73

Merged
sundar-pds merged 2 commits intoROCm:mainfrom
yuva29:multus-fix-cp
Apr 21, 2026
Merged

[CP 300] Fix multus config detection to support both .conf and .conflist formats (#300)#73
sundar-pds merged 2 commits intoROCm:mainfrom
yuva29:multus-fix-cp

Conversation

@yuva29
Copy link
Copy Markdown
Collaborator

@yuva29 yuva29 commented Apr 15, 2026

  • Fix multus config detection to support both .conf and .conflist formats

Multus auto-detects CNI config format based on primary CNI plugin. In K3s with Flannel, it creates .conflist instead of .conf.

  • Update device plugin init container to check for multus.conf*
  • Remove unused fileName from multus values.yaml
  • Add comment explaining auto-detection behavior
  • Address review comments

…ts (#300)

* Fix multus config detection to support both .conf and .conflist formats

Multus auto-detects CNI config format based on primary CNI plugin.
In K3s with Flannel, it creates .conflist instead of .conf.

- Update device plugin init container to check for *multus*.conf*
- Remove unused fileName from multus values.yaml
- Add comment explaining auto-detection behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address review comments

Signed-off-by: Yuva Shankar <11082310+yuva29@users.noreply.github.com>
@yuva29 yuva29 requested a review from sundar-pds April 15, 2026 19:30
Copy link
Copy Markdown
Collaborator

@sundar-pds sundar-pds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sundar-pds sundar-pds merged commit a54d48c into ROCm:main Apr 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants