You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sundar-pds Can we make sure pensando/v1.2.0 and pensando/main are in sync expect for the version changes? Sometimes the cherry-picker might have failed. Let's just make sure all the commits are there in pensando/main.
@sundar-pds Can we make sure pensando/v1.2.0 and pensando/main are in sync expect for the version changes? Sometimes the cherry-picker might have failed. Let's just make sure all the commits are there in pensando/main.
Thanks!
Thx for the review comment.
Yes, all change in v1.2.0 are present in main already , so we are covered there.
On the flip side, couple of commits in main are not present in 1.2.0.
Fix multus config detection to support both .conf and .conflist format
Fix kernel module loading order to prevent NetworkConfig deletion hang .
Second one (kmod) seems to be openshift specific.. so its not needed in v1.2.0 .
Do we need the first one cherry-picked to v1.2.0 @yuva29 ? I believe its more for a k3s requirement, which might not be needed in v1.2.0 . pls confirm .
@sundar-pds Can we make sure pensando/v1.2.0 and pensando/main are in sync expect for the version changes? Sometimes the cherry-picker might have failed. Let's just make sure all the commits are there in pensando/main.
Thanks!
Thx for the review comment. Yes, all change in v1.2.0 are present in main already , so we are covered there. On the flip side, couple of commits in main are not present in 1.2.0.
Fix multus config detection to support both .conf and .conflist format
Fix kernel module loading order to prevent NetworkConfig deletion hang .
Second one (kmod) seems to be openshift specific.. so its not needed in v1.2.0 . Do we need the first one cherry-picked to v1.2.0 @yuva29 ? I believe its more for a k3s requirement, which might not be needed in v1.2.0 . pls confirm .
Right (1) is a requirement for k3s. It need not go in v1.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync ROCM main branch with Pensando repo main branch changes.