Skip to content

Conversation

@evedovelli
Copy link

Motivation

Avoid inconsistency between list of officially supported architectures by hipTensor and the accepted list of architectures when building the examples.

Technical Details

Use a new cmake function provided by hipTensor instead of verifying the architecture against a locally maintained list of supported architectures.

Depends on ROCm/hipTensor#409

Test Plan

  1. rocm-examples built with CMAKE_HIP_ARCHITECTURES including only hipTensor supported architectures.
  2. rocm-examples built with CMAKE_HIP_ARCHITECTURES including hipTensor non-supported architectures.

Test Result

  1. Build including hipTensor examples, as expected.
  2. Build not including hipTensor examples, as expected.

Submission Checklist

@evedovelli evedovelli self-assigned this Oct 22, 2025
@evedovelli evedovelli requested a review from a team as a code owner October 22, 2025 15:53
@zichguan-amd
Copy link
Collaborator

Thanks so much for this change! Can you also change all the subfolders' CMake files that was modified in #324?

@evedovelli
Copy link
Author

Thanks so much for this change! Can you also change all the subfolders' CMake files that was modified in #324?

Sure! I'll change all of the CMake files.

Copy link
Collaborator

@zichguan-amd zichguan-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@evedovelli
Copy link
Author

Thanks for approving @zichguan-amd!

The rocm-examples is currently failing for this PR because the rocm version installed as dependency doesn't yet include my updates in hipTensor. I'll wait till the hipTensor changes are visible before merging this PR.

@evedovelli evedovelli force-pushed the users/evedovel/query-hiptensor-supported-architectures branch from be1f580 to c52ad2f Compare October 28, 2025 16:46
@evedovelli evedovelli requested a review from a team as a code owner October 28, 2025 16:46
@evedovelli evedovelli force-pushed the users/evedovel/query-hiptensor-supported-architectures branch from c52ad2f to 717b144 Compare October 28, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants