Remove alternative default device detection in Cubeb backend #17409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Vestrel care to take a look? |
Contributor
|
Well, if data is the same as in enumeration, then i don't mind removing it. My assumption was that some backends may not implement enumeration, so i wrote this fallback. Please also delete function declaration from header file. |
Signed-off-by: Marcin Serwin <[email protected]>
marcin-serwin
force-pushed
the
push-nwqrzqttmuqk
branch
from
50d2b0a to
fc034f9
Compare
Contributor
Author
|
More backends support enumeration than the fallback so it doesn't buy you anything at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cubeb_stream_get_current_devicefunction is considered for deletion, see mozilla/cubeb#822. Other than an outdated Firefox workaround, this is the only other place where I was able to find it being used. As far as I can tell, the alternative detection would not find anything more than theGetDevicefunction so I'm not exactly sure what was its purpose.Is there actually some platform where the fallback function works while the default device is not found using the
enumerate_devices?