Add application test for pctpairprotons#78
Conversation
SimonRit
left a comment
There was a problem hiding this comment.
The Python test fails because uproot is missing. Can you add an optional dependency https://github.com/RTKConsortium/RTK/blob/main/pyproject.toml#L171? Add then the option --group test on the line https://github.com/acoussat/PCT/blob/pctpairprotons-test/.github/workflows/build-test-package.yml#L51, see https://docs.openrtk.org/en/latest/INSTALLATION.html#testing.
67fa3ec to
8841a6b
Compare
Done!
We checked together with @axel-grc and it does not work, and it is not how it is currently done in RTK. I have decided to follow RTK and just copy the dependencies there. Is it something we ought to change in RTK?
I copied and adapted the text from RTK, but I noticed that the command |
SimonRit
left a comment
There was a problem hiding this comment.
Good as is but it might be worth considering uproot a mandatory in the future.
Following this comment.