pctweplfit update#81
Open
acoussat wants to merge 6 commits into
Open
Conversation
acoussat
force-pushed
the
pctweplfit-update
branch
from
0ccd1b9 to
941e110
Compare
acoussat
commented
Apr 27, 2026
acoussat
force-pushed
the
pctweplfit-update
branch
2 times, most recently
from
73ea09d to
ed30b3e
Compare
Collaborator
|
To be rebased on main after #80 is merged and test renamed accordingly. |
acoussat
force-pushed
the
pctweplfit-update
branch
2 times, most recently
from
4907eaf to
e1564b9
Compare
The previous behavior allowed to have values for phantom thickness larger than the proton range in water, which caused issues because no protons could traverse the phantom. Now, the maximum thickness is given by the approximate proton range in water, which is of about 26 cm. The parameter --phantom-length-samples defines the (evenly spaced) number of thicknesses to compute between 0 and the minimum between the proton range and the spacing between the detectors.
The text claimed that the examples uses energy-loss fit, whereas the command used TOF fit.
acoussat
force-pushed
the
pctweplfit-update
branch
from
e1564b9 to
3307df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several small updates concerning
pctweplfit:pctweplfitin order to properly handleopengate>=10.1.0pctweplfitwas trying to shoot protons through a quantity of water larger than the proton range, resulting in empty ROOT files and messing up the fitpctweplfitpctweplfit