ENH: Fix CUDA 2D FFT convolution for multi-projection inputs#941
Closed
axel-grc wants to merge 1 commit into
Closed
ENH: Fix CUDA 2D FFT convolution for multi-projection inputs#941axel-grc wants to merge 1 commit into
axel-grc wants to merge 1 commit into
Conversation
Process multi-projection 2D-kernel convolutions slice-by-slice in CudaFFTProjectionsConvolutionImageFilter instead of building one large stack-wide FFT problem. This avoids the oversized padded convolution volume seen with CudaScatterGlareCorrectionImageFilter on large projection stacks
Collaborator
|
Thanks for the fix. Projection-by-projection processing should be handled a priori, not in the filter in my opinion as this might have a cost computing time wise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process multi-projection 2D-kernel convolutions slice-by-slice in CudaFFTProjectionsConvolutionImageFilter instead of building one large stack-wide FFT problem.
This avoids the oversized padded convolution volume seen with CudaScatterGlareCorrectionImageFilter on large projection stacks
Fix #557