Additional commands#5
Open
RamyTalal wants to merge 2 commits into
Open
Conversation
added 2 commits
March 7, 2018 17:05
|
namespace Talal\LabelPrinter\Command; class CharColor implements CommandInterface } |
kcasarez
reviewed
May 30, 2019
| { | ||
| $this->addOption(new Format($this->format), 0); | ||
| $this->addOption(new Character(Character::OFF), 1); | ||
| $this->addOption(new Height(48), 2); |
There was a problem hiding this comment.
Suggested change
| $this->addOption(new Height(48), 2); | |
| $this->addOption(new Height(48), 3); |
kcasarez
reviewed
May 30, 2019
| $this->addOption(new Format($this->format), 0); | ||
| $this->addOption(new Character(Character::OFF), 1); | ||
| $this->addOption(new Height(48), 2); | ||
| $this->addOption(new Width(Width::SMALL), 3); |
There was a problem hiding this comment.
Suggested change
| $this->addOption(new Width(Width::SMALL), 3); | |
| $this->addOption(new Width(Width::SMALL), 4); |
kcasarez
reviewed
May 30, 2019
| $this->addOption(new Character(Character::OFF), 1); | ||
| $this->addOption(new Height(48), 2); | ||
| $this->addOption(new Width(Width::SMALL), 3); | ||
| $this->addOption(new Parenthesis(Parenthesis::ON), 4); |
There was a problem hiding this comment.
Suggested change
| $this->addOption(new Parenthesis(Parenthesis::ON), 4); | |
| $this->addOption(new Parenthesis(Parenthesis::ON), 2); |
kcasarez
suggested changes
May 30, 2019
kcasarez
left a comment
There was a problem hiding this comment.
Removed some extra characters that I don't know why they were added.
|
|
||
| public function read() | ||
| { | ||
| return 't' . $this->value . 'sp'; |
There was a problem hiding this comment.
Suggested change
| return 't' . $this->value . 'sp'; | |
| return 't' . $this->value; |
|
|
||
| public function read() | ||
| { | ||
| return 'r' . $this->value . 'uxy'; |
There was a problem hiding this comment.
Suggested change
| return 'r' . $this->value . 'uxy'; | |
| return 'r' . $this->value; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding additional commands for the printer.