Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.5
spatie/macroableto^2.1laminas/diactorosto^3.8phpunit/phpunitto^12Macroable is a necessary upgrade, but means we have to drop PHP <8.3
Changes to Closure handling
PHP 8.5 introduces changes to how closures are reported. Instead of just returning
'Closure'they now return more debugging information. To catch this, I've checked forClosureinstances:/** * Get the human readable name of this action * * @return string */ public function getActionName() { $callableName = null; if ($this->isControllerAction()) { return $this->controllerName . '@' . $this->controllerMethod; } + if ($this->callable instanceof \Closure) { + return 'Closure'; + } + if (is_callable($this->callable, false, $callableName)) { list($controller, $method) = explode('::', $callableName); - if ($controller === 'Closure') { - return $controller; - } - return $controller . '@' . $method; } }