modularize optimization internals

[ben-schwen]

• Closes Using Map instead of lapply turns GForce off #5336
• Closes lapply GForce opt could work also without .SD #5032
• Closes Move GForce tests to own script #4305
• Towards GForce optimisation could be more smart #3815
• Closes GForce as.double / as.numeric #2934
• Closes benchmark regression #7404
• tests (a lot of them)

Adds arithmetic for GForce as demanded in #3815 but does not add support for blocks in j like d[, j={x<-x; .(min(x))}, by=y].

[codecov]

Codecov Report

❌ Patch coverage is 99.61089% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.05%. Comparing base (b0c4ac3) to head (6c7e368).

Files with missing lines	Patch %	Lines
R/test.data.table.R	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7401      +/-   ##
==========================================
- Coverage   99.06%   99.05%   -0.02%     
==========================================
  Files          86       86              
  Lines       16618    16701      +83     
==========================================
+ Hits        16463    16543      +80     
- Misses        155      158       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

No obvious timing issues in HEAD=modular_gforce

Generated via commit 6c7e368

Download link for the artifact containing the test results: ↓ atime-results.zip

Task	Duration
R setup and installing dependencies	2 minutes and 58 seconds
Installing different package versions	21 seconds
Running and plotting the test cases	2 minutes and 41 seconds

[ben-schwen]

I'm also not sure about moving the tests to optimize.Rraw since this feels kind of wrong and not needed after introducing the new levels/optimization parameter to test.

[jangorecki]

It is rather a big change, and considering we are aiming for release soon, I think it will be safer to merge it to 1.18.99 rather than now

[ben-schwen]

It is rather a big change, and considering we are aiming for release soon, I think it will be safer to merge it to 1.18.99 rather than now

Fine for me. I will try to fix #7404 then with another patch. I guess that probably has something to do with the progress bar