Proposal to add properties and relationships to Alarms#250
Draft
Proposal to add properties and relationships to Alarms#250
Conversation
Contributor
|
A question; the ExceptionEvent that is part of all alarms (as a lastKnownValue component) already includes a Otherwise I'm ok with suggested changes. |
|
Does source need to be so specific? An alarm might be generated by a device and not have any explicit point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working through modeling BACnet and Niagara Edge Alarms, I'd like to propose:
sourcePointrelationship: Alarm should reference the Point/Points that are the source of the Alarm.eventIdentifierproperty: It's common for events to either generate a unique identifier, or use a reference number. This enables the events to be tracked and managed throughout it's lifecycle (important for ACK/clear on alarms)priorityproperty: It's common for controller events to have an associated priority in order to understand how the system or operators should order their responses.fromStateandtoStateproperties: Common pattern I'm seeing on controllers is capturing both from and to state, not just the generated message.I'm still working through with my teams how to capture acknowledge and clear of exception events, and plan to expand this PR. I'm also planning on capturing common alarm configurations (High limit, deadband, etc)