Skip to content

[WIP] Add search page - #73

Open
nth-chile wants to merge 12 commits into
RelistenNet:masterfrom
nth-chile:add-search
Open

[WIP] Add search page#73
nth-chile wants to merge 12 commits into
RelistenNet:masterfrom
nth-chile:add-search

Conversation

@nth-chile

@nth-chile nth-chile commented Oct 16, 2023

Copy link
Copy Markdown
480.mov

Why

  • Search for all versions of a song, so you don't have to click through a bunch of shows to find them
  • We could add artists to Relisten without showing them in the featured artists column, and still have them available if you search for them. There would be less of a reason to be selective about which artists to add

Todo

  • Before the user has entered a search query, the main section of the page should show the list of featured artists. Like Spotify
  • Do we need to sanitize/trim search input?
  • Add real duration for song versions list, I couldn't find it in the API response

@nth-chile
nth-chile marked this pull request as draft October 16, 2023 14:52
Comment thread src/app/(main)/(secondary)/search/page.tsx Outdated
Comment thread src/app/(main)/NavBar.tsx
<Link href="/search" legacyBehavior prefetch={false}>
<a className="nav-btn">SEARCH</a>
</Link>
</div>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running out of room on the nav. This goes behind the player

Comment thread src/components/Search.tsx Outdated

useDebouncedEffect(
() => {
// TODO: sanitize, trim ...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare the string so it's always a valid param

@nth-chile
nth-chile marked this pull request as ready for review January 5, 2024 23:33
Comment thread src/app/(main)/(secondary)/search/page.tsx Outdated
Comment thread src/app/(main)/(secondary)/search/page.tsx Outdated
@nth-chile nth-chile changed the title WIP: Add search page [WIP] Add search page May 20, 2024
@switz

switz commented Jul 1, 2025

Copy link
Copy Markdown
Member

I'd like to get this integrated, if you are interested in helping tag me in the discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants