Handle Streaming output the same the default output in AudioSystem update#83
Open
Handle Streaming output the same the default output in AudioSystem update#83
Conversation
Contributor
|
Why isn't it a transpiler? I really don't like these giant prefix method replacements. |
Contributor
Author
|
For now I'm not considering it fixed yet anyways, since there's still funkiness with the audio. The version we've been testing in Showman Tools has improved that, but I'd prefer if the userspace audio wouldn't be audible. Though I suppose that could be overlooked, since it is also audible when using the user's output directly, I think. But my main problem with transpilers is that they're a lot more annoying to write, and a lot harder to reason about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fix for Yellow-Dog-Man/Resonite-Issues#6211
Will wait for @Ondra-Kavan to test it on stream for confirmation that it is working properly. Preliminary testing suggested so.