Add switch to not display success messages#17
Open
Nekroze wants to merge 1 commit into
Open
Conversation
vanwarantion
suggested changes
May 18, 2020
Nekroze
force-pushed
the
toggle-found-messages
branch
2 times, most recently
from
226ca71 to
4547896
Compare
Owner
|
I just wanted to say thanks for the PR! 👏 |
RestlessThinker
requested changes
May 20, 2020
RestlessThinker
left a comment
RestlessThinker
left a comment
Owner
There was a problem hiding this comment.
@Nekroze Thanks again for the PR! Can you update the README as well with your new parameter change? Also, extra credit for adding a test case for this!
Gitlab has its own jira integration that does a good job of displaying all mentioned jira issues, in this case the message is uneccesary however the messages on no jira being mentioned is still of value.
Nekroze
force-pushed
the
toggle-found-messages
branch
from
4547896 to
a43fdbf
Compare
Author
|
I did not add a test case as this is the most ruby I have every really written that wasn't just config and that is a whole rabbit hole I sadly don't have time for at present sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitlab has its own jira integration that does a good job of displaying
all mentioned jira issues, in this case the message is uneccesary
however the messages on no jira being mentioned is still of value.