Restore Old Package & Offering Initializer APIs #5474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
changed the title
fire-at-will
changed the title
📸 Snapshot Test1 modified, 704 unchanged
🛸 Powered by Emerge Tools |
Contributor
Author
|
@RCGitBot please test |
tonidero
approved these changes
Aug 14, 2025
Contributor
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
This looks good! Just a couple of non-blocker comments.
|
|
||
| /// Initialize an ``Offering`` given a list of ``Package``s. | ||
| @objc | ||
| public convenience init( |
Contributor
There was a problem hiding this comment.
I wonder, should we deprecate these constructors? Not sure if we want to push devs into just a single constructor... Maybe we should even try to make the "main" constructor internal to avoid these issues but we would need to keep the current ones public for backwards compatibility
JZDesign
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In release 5.23.0, we unintentionally broke the public API for the
OfferingandPackageinitializers by adding a non-optionalwebCheckoutUrl: URL?parameter.The breaking changes were introduced in the these PRs/commits:
Description
This PR restores the previous API by re-introducing new public initializers for these structs that omit the webCheckoutUrl parameter, matching the API contracts prior to 5.23.0. It also adds these re-introduced constructors to the API testers.
This PR introduces entirely new convenience initializers rather than adding a default value of nil to the existing ones, because initializers with default parameter values aren’t exposed to Objective-C. Simply adding a default would not restore the original Objective-C API.