Format test store price strings with same currency code and locale as localizedPriceString #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test240 unchanged
🛸 Powered by Emerge Tools |
rickvdl
force-pushed
the
rickvdl/test-store-formatted-price-string-currency-code
branch
2 times, most recently
from
88cf0f5 to
b8e39d5
Compare
Contributor
Author
|
@RCGitBot please test |
rickvdl
commented
Nov 14, 2025
| expect(storeProduct.isFamilyShareable) == isFamilyShareable | ||
| } | ||
|
|
||
| // Legacy behavior: if no currencyCode is passed it will take the currencyCode from the locale |
Contributor
Author
There was a problem hiding this comment.
Not sure how I feel about this implicit behavior when using the backwards compatible initializer. However this is how it worked before, so I'm not sure...
…tting a price string
…her price strings for Test Store product
…eProduct initializer
rickvdl
force-pushed
the
rickvdl/test-store-formatted-price-string-currency-code
branch
from
d6b4932 to
5950228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Some internal context here. Basically the
localizedPriceString(the pre-formatted product price) was formatted using theprice.currencyfrom the actual product here . Whereas all the other prices were formatted using theTestStoreProduct's priceFormatter, which was configured to use theTestStoreProduct'slocale.rc_currencyCode, which was AFAIK alwaysLocale.current, which means that the formatted prices would be formatted according to the device's locale. Which will often be different from the product's currency.TL;DR.
localizePriceStringused the product's currency, all other formatted strings used the device's locale's currency, causing discrepancies.Description
This was fixed by passing the
currencyCodeto theTestStoreProduct, ensuring it can format prices using the correct currencyCode. A fallback using the old behavior is still in place in order to maintain backwards compatibility (the public API of theTestStoreProductinitializer).