-
Notifications
You must be signed in to change notification settings - Fork 6
Add context workflow identifier support #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context workflow identifier support #649
Conversation
tonidero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering if this should be a parameter for presentPaywall/purchase methods, instead of a configuration parameter... thoughts?
elenaperezrioja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will be passed when calling _trackEvent, right? which is good, but we're already passing it in the properties of the event.
We're not passing the workflow id when a purchase is happening so that we can access it in khepri after the transaction is created, right?
tonidero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we make these APIs internal, this looks good! And also, I would consider renaming the PurchasesContext to PresentedWorkflowContext, so it's more concrete and similar to the PresentedOfferingContext that has a similar utility.
|
What about: So that in the future we can extend the context and still have an object for the presentedWorkflowContext? |
I like that! |
That's great :) I can imagine needing to pass some additional info like workflowRevision at some point |
tonidero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! 🚢
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix `identifyUser` wasCreated (#654) via Toni Rico (@tonidero) ### 🔄 Other Changes * Add workflowIdentifier to PresentedOfferingContext interface (#651) via Elena Pérez Rioja (@elenaperezrioja) * Add context workflow identifier support (#649) via Nicola Sacco (@nicfix)
Summary
Purchases.configureto accept an optional context with a workflow identifierEventsTrackerand include it on emitted eventsTesting
Codex Task