-
Notifications
You must be signed in to change notification settings - Fork 6
Add workflowIdentifier to PresentedOfferingContext interface #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tonidero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes make sense! Only thing is that if we add the PresentedWorkflowContext inside PurchasesContext, it might change the implementation slightly, but we can fix it if/when we do that.
src/networking/backend.ts
Outdated
|
|
||
| if (this.purchasesContext?.workflowIdentifier) { | ||
| requestBody.presented_workflow_id = | ||
| this.purchasesContext.workflowIdentifier; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might end up adding an intermediate PresentedWorkflowContext in the base PR, so this might change slightly, but can wait until that's done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stacked on tocp of that PR, so when that changes, I'll change this one
05e89c1 to
320b899
Compare
320b899 to
d22c6e9
Compare
d22c6e9 to
deb8188
Compare
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix `identifyUser` wasCreated (#654) via Toni Rico (@tonidero) ### 🔄 Other Changes * Add workflowIdentifier to PresentedOfferingContext interface (#651) via Elena Pérez Rioja (@elenaperezrioja) * Add context workflow identifier support (#649) via Nicola Sacco (@nicfix)

Motivation / Description
Pass workflow_identifier when making a purchase. This will be added in the backend to the purchase session and will let us identify that a puchase came from navigating a workflow.
Changes introduced
Using the workflow is present in the purchases context to send it in the checkout request
Linear ticket (if any)
Additional comments