Make path to .gitignore.d and .gitattributes.d configurable #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
requested changes
Apr 3, 2021
Collaborator
alerque
left a comment
alerque
left a comment
There was a problem hiding this comment.
Mostly I think this code looks like it is on the right track as far at it goes. Before we merge it however I think we should at least add a check that throws a warning if the default settings are changed but the legacy default location still has matching files, then perhaps extend vcsh upgrade with a fix.
In fact I might even make a case that in addition to providing this configurable option we should change the default to be somewhere in $XDG_DATA_HOME, cf. #166.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving #203 with some dark magic.
Closes #180.