feat: add codex_app_server LLM driver and provider registration#1216
Open
mvanhorn wants to merge 3 commits into
Open
feat: add codex_app_server LLM driver and provider registration#1216mvanhorn wants to merge 3 commits into
mvanhorn wants to merge 3 commits into
Conversation
Previously matched via substring contains, which would zero-cost any user-named model containing the provider id (e.g. my-codex_app_server- eval). Now requires exact match or canonical 'provider/model' prefix.
The driver declares supports_tools: false in the catalog and rejects all in-protocol tool requests, so callers passing CompletionRequest tools were silently getting text-only output. Log a warning with the dropped tool count and model so misconfiguration surfaces rather than producing degraded agent behavior.
danishsarwar99
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: add codex_app_server LLM driver and provider registration
Closes #1033
AI was used for assistance.