chore: remove unused pnpm-lock.yaml#87
Merged
Merged
Conversation
CI installs with `npm ci` and caches npm; nothing in this repo builds from pnpm. The pnpm lockfile had drifted well behind package-lock.json (hono 4.12.19 vs 4.12.25, dompurify 3.2.7 vs 3.4.12) and was the source of 47 stale Dependabot alerts against dependencies that were already patched in the lockfile we actually use.
Guards against pnpm-lock.yaml/yarn.lock reappearing and re-creating the duplicate-alert problem.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo had two lockfiles at root. CI runs
npm ciwithcache: npm, sopnpm-lock.yamlwas never used to build anything — but Dependabot scanned it anyway.It had drifted badly behind the lockfile we actually use:
That accounted for 47 of 60 open Dependabot alerts — all against a file nothing builds from, for versions already patched in
package-lock.json.Also adds
pnpm-lock.yamlandyarn.lockto.gitignoreso a straypnpm installcannot re-create the problem.verifypassing on this PR is the proof nothing depended on the removed file.