-
Notifications
You must be signed in to change notification settings - Fork 63
(CI) use newer lint action #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Current one fails to run, but this doesn't show because of settings
|
Disabled this via: The bot does not react correctly on updates on the pull request branch which means people have to manually dismiss bot reviews. |
|
But the current version is broken, j2kun/chktex-action#40 So I suggest to use the new version, but always check all files. So the behaviour doesn't change. But at least it works again. |
|
The new version uses a Github bot setup to automatically suggest changes but will not update them: thus it opens change requests and blocks all pulls which then require manual intervention. We ignored the output anyway. We can remove the action for now. |
|
I will do some tests to check whether we can disable the review functionality |
Current one fails to run, but this doesn't show because of settings
The new action allows for checking only updated files in a PR. When we would do that, we could remove the
continue-on-error. And enforce the linting on updated files. Which would slowly increase the linting on the entire rulebook.