Skip to content

Conversation

@MatthijsBurgh
Copy link
Collaborator

@MatthijsBurgh MatthijsBurgh commented Mar 19, 2025

Current one fails to run, but this doesn't show because of settings

The new action allows for checking only updated files in a PR. When we would do that, we could remove the continue-on-error. And enforce the linting on updated files. Which would slowly increase the linting on the entire rulebook.

Current one fails to run, but this doesn't show because of settings
@LeroyR
Copy link
Member

LeroyR commented Mar 19, 2025

Disabled this via:
#937

The bot does not react correctly on updates on the pull request branch which means people have to manually dismiss bot reviews.
This is too confusing for contributors.

@LeroyR LeroyR closed this Mar 19, 2025
@MatthijsBurgh MatthijsBurgh reopened this Mar 19, 2025
@MatthijsBurgh
Copy link
Collaborator Author

MatthijsBurgh commented Mar 19, 2025

But the current version is broken, j2kun/chktex-action#40

So I suggest to use the new version, but always check all files. So the behaviour doesn't change. But at least it works again.

@LeroyR
Copy link
Member

LeroyR commented Mar 19, 2025

The new version uses a Github bot setup to automatically suggest changes but will not update them: thus it opens change requests and blocks all pulls which then require manual intervention.

We ignored the output anyway. We can remove the action for now.
I am open to enable this again after all checks pass to test that behavior again.

LeroyR
LeroyR previously requested changes Mar 19, 2025
@LeroyR LeroyR dismissed their stale review March 19, 2025 14:06

out of date

@MatthijsBurgh
Copy link
Collaborator Author

I will do some tests to check whether we can disable the review functionality

@LeroyR LeroyR marked this pull request as draft April 14, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants