Create VINCA_CUSTOM_CMAKE_BUILD_DIR directory if not exists#116
Merged
Tobias-Fischer merged 1 commit intoRoboStack:masterfrom Mar 12, 2026
Merged
Create VINCA_CUSTOM_CMAKE_BUILD_DIR directory if not exists#116Tobias-Fischer merged 1 commit intoRoboStack:masterfrom
Tobias-Fischer merged 1 commit intoRoboStack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes #115 which was adding a feature to use
VINCA_CUSTOM_CMAKE_BUILD_DIRenv var as CMake build dir if set.However, if the variable is set but the directory does not, this will just skip this and give no error as it.
We could either enforce the corresponding directory to be created first (and add a test here), or create the corresponding directory here if not already existing, which is what this PR propose.
Sorry to have missed that in #115.