Conversation
sea-bass
left a comment
There was a problem hiding this comment.
Just noting this is introducing ABI incompatibilities, presumably even to older "stable" distros. Are we okay with this? I personally think this is fine unless there are other packages released to the buildfarm that rely on this. But if this is a true "leaf" package, then let's send it.
There are no packages in rosdistro that link against this library. Also, The API and ABI were already broken by the latest refactor (#192) |
This PR adds clang-tidy check using
ament_clang_tidy. The check is disabled by default and can be enabled usingENABLE_CLANG_TIDYCMake option. Two reasons behind it:The motivation behind clang-tidy was the readability-identifier-naming check which codifies naming conventions as requested in this discussion
The few other basic checks like
google-*,misc-*,readability-*seem to completely supersedecpplintso I removed it.