ros_compressed: Reconfigure compressed topic from request#96
Open
sfalexrog wants to merge 2 commits intoRobotWebTools:ros1from
Open
ros_compressed: Reconfigure compressed topic from request#96sfalexrog wants to merge 2 commits intoRobotWebTools:ros1from
sfalexrog wants to merge 2 commits intoRobotWebTools:ros1from
Conversation
Member
|
Could you rebase your commit or merge changes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P/R adds handling of the following request parameters for
ros_compressedtopics:quality: setsjpeg_qualityparameter for compressed topic;level: setspng_levelparameter for compressed topic;format: sets the output format (accepted values arejpegandpng).The code in this P/R is written with the assumption that the
/compressedimage topic is published bycompressed_image_transportand thus has the required reconfigurable parameters.Note that this adds build-time and run-time dependencies on the
dynamic_reconfigurepackage.