Update dotnet monorepo - #2410
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The PR successfully updates several Microsoft AspNetCore and Extensions packages to newer versions. According to Codacy analysis, the changes are up to standards, and no new quality issues were introduced.
However, the review identified a systemic redundancy in the package configuration. Specifically, multiple packages are defined twice within the same ItemGroup in Directory.Packages.support.props. While this does not break the build, it introduces maintenance risk and should be resolved before merging to maintain a clean configuration. No critical security flaws or major logic bugs were detected.
About this PR
- The Directory.Packages.support.props file contains several duplicate PackageVersion entries. This pattern can lead to configuration drift if future updates only target one of the duplicate lines. It is recommended to standardize on a single entry per package.
Test suggestions
- Verify project compilation and assembly resolution with the updated package versions.
- Ensure existing automated tests pass to verify no regressions in patch/minor version updates.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify project compilation and assembly resolution with the updated package versions.
2. Ensure existing automated tests pass to verify no regressions in patch/minor version updates.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| <PackageVersion Update="Microsoft.AspNetCore.Components.WebAssembly" Version="8.0.28" /> | ||
| <PackageVersion Update="Microsoft.AspNetCore.Components.WebAssembly.Server" Version="8.0.28" /> | ||
| <PackageVersion Update="Microsoft.AspNetCore.TestHost" Version="8.0.28" /> |
There was a problem hiding this comment.
⚪ LOW RISK
Suggestion: Remove redundant package version declarations. The entries for Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, and Microsoft.AspNetCore.TestHost are already defined on lines 4, 5, and 7.
Try running the following prompt in your IDE agent:
Remove the duplicate PackageVersion entries for 'Microsoft.AspNetCore.Components.WebAssembly', 'Microsoft.AspNetCore.Components.WebAssembly.Server', and 'Microsoft.AspNetCore.TestHost' from Directory.Packages.support.props, keeping only the first occurrence of each.
SummarySummary
CoverageAspire.Hosting.Tests - 30.8%
AspireSample - 1.6%
Rocket.Surgery.CommandLine - 23.6%
Rocket.Surgery.Conventions - 18.3%
Rocket.Surgery.Conventions.Abstractions - 49.4%
Rocket.Surgery.Conventions.Analyzers - 77.6%
Rocket.Surgery.Conventions.Analyzers.Tests - 69%
Rocket.Surgery.Conventions.Autofac - 14.9%
Rocket.Surgery.Conventions.Configuration.Json - 27.9%
Rocket.Surgery.Conventions.Configuration.Yaml - 18.6%
Rocket.Surgery.Conventions.Diagnostics - 15.3%
Rocket.Surgery.Conventions.DryIoc - 18.3%
Rocket.Surgery.Conventions.Tests - 67.5%
Rocket.Surgery.Extensions.Autofac.Tests - 29.2%
Rocket.Surgery.Extensions.CommandLine.Tests - 25.2%
Rocket.Surgery.Extensions.DryIoc.Tests - 31.3%
Rocket.Surgery.Hosting - 3.4%
Rocket.Surgery.Hosting.AspNetCore.Tests - 27.2%
Rocket.Surgery.Hosting.Tests - 26.2%
Rocket.Surgery.WebAssembly.Hosting - 0%
Rocket.Surgery.WebAssembly.Hosting.Tests - 0%
Sample - 1.2%
Sample.Core - 13.4%
Sample.Core.Tests - 0%
Sample.DependencyOne - 0%
Sample.DependencyThree - 0%
Sample.DependencyTwo - 0%
Sample.Tests - 9.5%
|
d16f203 to
4799d71
Compare
f52a1d8 to
5e2e3cc
Compare
4e7d981 to
28d2c83
Compare
28d2c83 to
b1120ef
Compare
This PR contains the following updates:
8.0.24→8.0.3010.0.9→10.0.118.0.24→8.0.3010.0.9→10.0.118.0.24→8.0.3010.0.9→10.0.118.0.24→8.0.3010.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.3→10.0.1110.0.9→10.0.1110.0.300→10.0.4009.0.0→9.0.199.0.9→9.0.1910.0.9→10.0.1110.0.301→10.0.400Release Notes
dotnet/dotnet (Microsoft.AspNetCore.Components.WebAssembly)
v10.0.11v10.0.10dotnet/sdk (dotnet-sdk)
v10.0.400Compare Source
v10.0.303Compare Source
v10.0.302: .NET 10.0.10Compare Source
Release
What's Changed
PosixSignalRegistrationby @jonathanpeppers in #52466dotnet runby @jonathanpeppers in #52608dotnet run -e FOO=BARpasses@(RuntimeEnvironmentVariable)by @jonathanpeppers in #526642902832by @dotnet-bot in #53009$(Device)global property missing duringDeployToDevicetarget by @jonathanpeppers in #53018#:includeby @jjonescz in #523472912121by @dotnet-bot in #531232914767by @dotnet-bot in #53195dotnet tool exec- running dnx is implicit approval by @marcpopMSFT with @Copilot in #529562918587by @dotnet-bot in #532442918883by @dotnet-bot in #532702921244by @dotnet-bot in #53323--artifacts-pathsupport todotnet testin MTP mode by @Youssef1313 with @Copilot in #53353.csin file-based app virtual.csprojfile name by @jjonescz in #53182dotnet tool exec/dnxfailing when tool exists indotnet-tools.jsonbut not yet restored by @marcpopMSFT with @Copilot in #53361NETSDK1005when project refs different TFMs by @jonathanpeppers in #535232934590by @dotnet-bot in #53554dotnet reference add/removefailing when no--projectis specified by @github-actions[bot] in #536012938097by @dotnet-bot in #536192938919by @dotnet-bot in #536242943136by @dotnet-bot in #53690Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.