Skip to content

Comments

ci: trigger code-qa workflow on pull_request_review approval#11636

Merged
hannesrudolph merged 1 commit intomainfrom
fix/ci-trigger-on-review-approval
Feb 20, 2026
Merged

ci: trigger code-qa workflow on pull_request_review approval#11636
hannesrudolph merged 1 commit intomainfrom
fix/ci-trigger-on-review-approval

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Feb 20, 2026

Problem

Changeset version bump PRs (opened by the github-actions[bot] using GITHUB_TOKEN) do not fire pull_request events that trigger other workflows. This is a GitHub platform restriction — workflows cannot trigger other workflows via GITHUB_TOKEN. As a result, the required CI checks (compile, knip, check-translations, platform-unit-test) never run on these PRs and remain perpetually "waiting for status to be reported".

Fix

Adds a pull_request_review trigger to code-qa.yml so CI fires when a code owner approves the PR. Each job includes an if guard so the workflow only runs on review events when the review state is approved, avoiding spurious runs on comments or change requests.

Start a new Roo Code Cloud session on this branch

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 20, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 20, 2026
@hannesrudolph hannesrudolph merged commit a55c85a into main Feb 20, 2026
20 checks passed
@hannesrudolph hannesrudolph deleted the fix/ci-trigger-on-review-approval branch February 20, 2026 18:33
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 20, 2026
hannesrudolph added a commit that referenced this pull request Feb 20, 2026
…#11639)

Revert "ci: trigger code-qa workflow on pull_request_review approval (#11636)"

This reverts commit a55c85a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants